-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitles are appearing on top of of yomitan on youtube videos #454
Comments
Can you link to the website you're seeing the problem on? I can't reproduce it |
In some sense the subtitles are behaving correctly by being on top of everything but in the sense that this is problematic for most users this is a bug |
I did try adding custom css in the I am guessing that it has something to do with yomitan being in a different stacking context than that of asbplayer. For now a refresh of the page seems to be the only solution. |
I am hitting the same issue, but with Migaku, which has similar functionality to Yomitan: it shows a popup dictionary. The problem is that asbplayer custom CSS applies to the subtitle In my case, refreshing the page does not fix the issue. It would be nice to somehow adjust asbplayer's injected stylesheet to adjust this top-level |
Got it, may need to implement a way to change the CSS of the container or reconsider the usefulness of the container. |
Alternatively, if the default could be made something like half of the maximum value instead of the maximum value. I can modify the CSS of the pop up in jpd-breader so I could then set it higher. Ideally a setting would be preferable, but that would unblock some use cases and be relatively simpler. |
I did a find and replace for 2147483647 and replaced it with 2147483646 and then set the z-index to 2147483647 in jpd-breader and that worked :) |
Good to know. I am planning to fix this officially within asbplayer as well - might just end up making it a setting. |
Using yomitan with asbplayer has suddnely become quite the problem for me since the 1.3.1 release.
Both yomitan and asbplayer have their zindex maxed out at 2147483647. Annoyingly yomitan's root dom node ends up higher up in the document tree than
<div class=asbplayer-subtitles-container-*">
and ends up being covered up by the subtitles, making it impossible to use.Thanks for your hard work.
The text was updated successfully, but these errors were encountered: