Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loader silently fails during unique key lookup #649

Open
znatty22 opened this issue Nov 1, 2022 · 0 comments
Open

Loader silently fails during unique key lookup #649

znatty22 opened this issue Nov 1, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@znatty22
Copy link
Member

znatty22 commented Nov 1, 2022

The loader is silently failing in this step:

because the key lookup is enclosed in a generic try/except causing it to miss real exceptions.

This recently happened when it tried to create the key for a phenotype using the event age but a ValueError was thrown due to an invalid int conversion. The ValueError was hidden due to the line above and the ingest library user did not know why the phenotype was not loaded.

We should make a custom exception that gets thrown for known error conditions during unique key lookup

@znatty22 znatty22 added the bug Something isn't working label Nov 1, 2022
@znatty22 znatty22 self-assigned this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant