dataservice family relationship filtering by participant ID returns relationships that don't include the given participant

[fiendish]

https://kf-api-dataservice.kidsfirstdrc.org/family-relationships?participant_id=PT_43KBFVQ3&limit=1

returns (neither participant matches the requested one)
{
_links: {
self: "/family-relationships"
},
_status: {
code: 200,
message: "success"
},
limit: 1,
results: [
{
_links: {
collection: "/family-relationships",
participant1: "/participants/PT_F76RVQ1J",
participant2: "/participants/PT_9A61PCYB",
self: "/family-relationships/FR_N23TR0NB"
},
created_at: "2018-06-12T14:51:15.589638+00:00",
external_id: null,
kf_id: "FR_N23TR0NB",
modified_at: "2018-06-12T14:51:15.589643+00:00",
participant1_to_participant2_relation: "Mother",
participant2_to_participant1_relation: "Child",
source_text_notes: null,
visible: true
}
],
total: 2
}

[dankolbman]

participant_id isn't a field on the family-relationships model. I think the problem here is that we are not verbose about filters that are invalid and return all results by default.

You could probably get what you want with this query:
https://kf-api-dataservice.kidsfirstdrc.org/family-relationships?participant1_id=PT_43KBFVQ3&limit=1

[fiendish]

@dankolbman It does filter though, as evidenced by getting total: 2 vs a much higher number. I think this is intended to be a filter, but it's giving the wrong family members (I think from the right family).

[dankolbman]

Hm I see. It looks like participant_id is a special filter that tries to get all relationships for the given participant. There may be an error in this function here https://github.com/kids-first/kf-api-dataservice/blob/master/dataservice/api/family_relationship/models.py#L79 @znatty22

[znatty22]

Yea I remember this was intentional, but it is a little confusing. We had requests for getting back all the family relationships for a participant and its family members. So this filter returns relationships for the participant and the participant's family members - https://github.com/kids-first/kf-api-dataservice/blob/f4805a7b17f3b8b80c1daa938e897dcd9434610f/dataservice/api/family_relationship/models.py#L87

[fiendish]

shouldn't that use a family id, then?