From 0f717fb4d37f24e97bb399a4676b91926dd3d784 Mon Sep 17 00:00:00 2001 From: yardasol Date: Mon, 26 Feb 2024 09:22:14 -0600 Subject: [PATCH 1/3] cleanup releasenote formatting --- doc/releasenotes/v0.5.0.rst | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/releasenotes/v0.5.0.rst b/doc/releasenotes/v0.5.0.rst index 2492cfa04..ea229a285 100644 --- a/doc/releasenotes/v0.5.0.rst +++ b/doc/releasenotes/v0.5.0.rst @@ -41,7 +41,7 @@ Dependency Changes Describe any new/removed/modified package dependencies -- ``SaltProc`` now requires the following package: +- ``SaltProc`` now requires the following packages: - (new) → `openmc`_ - (new) → `serpentTools`_ @@ -70,8 +70,9 @@ Bug Fixes .. Describe any bug fixes. -- `Fix bug where Serpent2 material temperatures are hardcoded to 900K in the JEFF 3.1.2 library format. ` -- `Fix bug where using MCNP-style ZAID codes results in an error in various SerpentDepcode functions ` +- `Fix bug where Serpent2 material temperatures are hardcoded to 900K in the JEFF 3.1.2 library format. `_ by `@yardasol`_ +- `Fix bug where using MCNP-style ZAID codes results in an error in various SerpentDepcode functions `_ by `@yardasol`_ +- `Fix bug where only one array of OpenMC Materials are stored in results `_ by `@yardasol`_ @@ -260,6 +261,5 @@ The following people reviewed code for this release of SaltProc: - `@LukeSeifert `_ - `@munkm `_ - `@abachma2 `_ - - - +- `@samgdotson `_ +- `@ZoeRichter `_ From e5c96d47cd210bd5cb54ccf069e01b4547cf503c Mon Sep 17 00:00:00 2001 From: yardasol Date: Mon, 26 Feb 2024 12:59:09 -0600 Subject: [PATCH 2/3] address @LukeSeifert's comments --- doc/releasenotes/v0.5.0.rst | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/doc/releasenotes/v0.5.0.rst b/doc/releasenotes/v0.5.0.rst index ea229a285..26846b9c8 100644 --- a/doc/releasenotes/v0.5.0.rst +++ b/doc/releasenotes/v0.5.0.rst @@ -107,10 +107,10 @@ Python API Changes - Input file format changes: - Removed the ``-n`` command line argument in favor of the new ``mpi_args`` input parameter - - Chaged the ``-d`` command line argument to ``-s``/``--threads``. + - Changed the ``-d`` command line argument to ``-s``/``--threads``. - (new) → ``mpi_args`` - Added default values for certain input parameters - - Adds a ``zaid_convention`` input parameter + - Added a ``zaid_convention`` input parameter - Added depletion settings for OpenMC - ``num_depsteps`` → ``n_depletion_steps`` - ``depcode['template_inputfile_path']`` → ``depcode['template_input_file_path']`` @@ -199,13 +199,13 @@ Python API Changes - ``reprocessing()`` → ``reprocess_materials()`` - ``refill()`` → ``refill_materials()`` - - ``read_feeds_from_input`` → ``get_feeds()`` - - ``read_processes_from_input`` → ``get_extraction_processes()`` + - ``read_feeds_from_input()`` → ``get_feeds()`` + - ``read_processes_from_input()`` → ``get_extraction_processes()`` - ``read_dot()`` → ``get_extraction_process_paths()`` - ``Process`` - - ``calc_rem_efficiency()`` → ``calculate_removal_efficiency`` + - ``calc_rem_efficiency()`` → ``calculate_removal_efficiency()`` - ``Reactor`` From 89878cdeb69e1904a37894897504e67abac46343 Mon Sep 17 00:00:00 2001 From: yardasol Date: Mon, 26 Feb 2024 13:38:51 -0600 Subject: [PATCH 3/3] address @LukeSeifert's comments --- doc/releasenotes/v0.5.0.rst | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/releasenotes/v0.5.0.rst b/doc/releasenotes/v0.5.0.rst index 26846b9c8..d35bbfd2f 100644 --- a/doc/releasenotes/v0.5.0.rst +++ b/doc/releasenotes/v0.5.0.rst @@ -136,7 +136,7 @@ Python API Changes - ``Depcode`` - - Add `output_path` parameter. + - Added `output_path` parameter. - ``template_inputfile_path`` → ``template_input_file_path`` - Removed default values for `geo_files` - Changed `iter_inputfile`, `iter_matfile` to be attributes instead of parameters @@ -155,7 +155,7 @@ Python API Changes - ``DepcodeSerpent`` → ``SerpentDepcode`` - - Add `output_path` parameter. + - Added `output_path` parameter. - ``template_inputfile_path`` → ``template_input_file_path`` - Removed default values for `exec_path`, `template_input_file_path`, `geo_files` - Changed `iter_inputfile`, `iter_matfile` to be attributes instead of parameters @@ -225,11 +225,11 @@ Python API Changes - ``Sparger`` - - ``calc_rem_efficiency()`` → ``calculate_removal_efficiency`` + - ``calc_rem_efficiency()`` → ``calculate_removal_efficiency()`` - ``Separator`` - - ``calc_rem_efficiency()`` → ``calculate_removal_efficiency`` + - ``calc_rem_efficiency()`` → ``calculate_removal_efficiency()`` Contributors