Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Options Menu #141

Closed
kheina opened this issue Jun 20, 2023 · 1 comment
Closed

Rework Options Menu #141

kheina opened this issue Jun 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@kheina
Copy link
Collaborator

kheina commented Jun 20, 2023

as we add more features, especially those that are going to require additional menu options, it's probably going to become necessary to create an advanced options menu or a full options menu rather than putting it all in the context menu. as it is, if you have both popups and threshold enabled, a scrollbar appears.

so, I'd like to propose that:

  1. we remove a few options that currently exist in the context menu and create a new settings page for them
  2. the context menu never becomes so large that the browser creates a scrollbar for it
  3. all current options and any new options are placed in the settings menu

I also think that the options that should stay in the context menu are only those that someone could conceivably want to change multiple times and not "set and forget"

options like:

  • pausing/unpausing (along with any other similar options like pause queue consumer)
  • showing or hiding popups, the timer probably doesn't need to be there, though
  • mute vs block
  • the threshold and value
  • maybe the nft one?
  • the block interval

the rest of the space in the context menu could be used for state or even just left blank

@kheina kheina added the enhancement New feature or request label Jun 20, 2023
@kheina
Copy link
Collaborator Author

kheina commented Jun 25, 2023

I went for tabs rather than a whole new page for advanced. I thought it looked a lot cleaner this way. it doesn't currently work because all of the options are denoted by ids, and everything in duplicated from basic to advanced, so the second id is ignored by the js
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant