From 61e32d630a655c9e0416a65f72a4fd6f61b87a19 Mon Sep 17 00:00:00 2001 From: Jason Kai Date: Fri, 31 Mar 2023 13:58:02 -0400 Subject: [PATCH 1/3] add manual trigger of workflow --- .github/workflows/python-testing.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/python-testing.yml b/.github/workflows/python-testing.yml index c0f54030..98eb5baf 100644 --- a/.github/workflows/python-testing.yml +++ b/.github/workflows/python-testing.yml @@ -5,6 +5,7 @@ name: Python package on: push: + workflow_dispatch: # branches: [ main ] # pull_request: # branches: [ main ] From fc7f7252087ef4f7534c7045b4dd7572ef39bff3 Mon Sep 17 00:00:00 2001 From: Jason Kai Date: Fri, 31 Mar 2023 14:06:33 -0400 Subject: [PATCH 2/3] update workflow action dependencies --- .github/workflows/bump_version.yml | 2 +- .github/workflows/dags.yml | 2 +- .github/workflows/manual_release_drafter.yml | 2 +- .github/workflows/push_container.yml | 2 +- .github/workflows/python-testing.yml | 16 ++++++++-------- 5 files changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/workflows/bump_version.yml b/.github/workflows/bump_version.yml index 4d583309..0ab3e332 100644 --- a/.github/workflows/bump_version.yml +++ b/.github/workflows/bump_version.yml @@ -7,7 +7,7 @@ jobs: build: runs-on: ubuntu-latest steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@master - name: Update changelog uses: release-drafter/release-drafter@v5 diff --git a/.github/workflows/dags.yml b/.github/workflows/dags.yml index e3fdff09..e3f27d3d 100644 --- a/.github/workflows/dags.yml +++ b/.github/workflows/dags.yml @@ -30,7 +30,7 @@ jobs: ref: refs/heads/master - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: ${{ matrix.python-version }} - name: Install non-python dependencies diff --git a/.github/workflows/manual_release_drafter.yml b/.github/workflows/manual_release_drafter.yml index 80af6667..1d7294f4 100644 --- a/.github/workflows/manual_release_drafter.yml +++ b/.github/workflows/manual_release_drafter.yml @@ -20,7 +20,7 @@ jobs: echo "Date: ${{ github.event.inputs.date }}" echo "Comments: ${{ github.event.inputs.comments }}" - - uses: actions/checkout@v2 + - uses: actions/checkout@master - name: Update changelog uses: release-drafter/release-drafter@v5 diff --git a/.github/workflows/push_container.yml b/.github/workflows/push_container.yml index b5eb6058..b648935e 100644 --- a/.github/workflows/push_container.yml +++ b/.github/workflows/push_container.yml @@ -19,7 +19,7 @@ jobs: contents: read steps: - name: Check out the repo - uses: actions/checkout@v2 + uses: actions/checkout@master - name: Log in to Docker Hub uses: docker/login-action@f054a8b539a109f9f41c372932f1ae047eff08c9 diff --git a/.github/workflows/python-testing.yml b/.github/workflows/python-testing.yml index 98eb5baf..d248cbf7 100644 --- a/.github/workflows/python-testing.yml +++ b/.github/workflows/python-testing.yml @@ -16,12 +16,12 @@ jobs: runs-on: ubuntu-latest steps: - name: Clone repo - uses: actions/checkout@v2 + uses: actions/checkout@master - name: Setup Python - uses: actions/setup-python@v2 + uses: actions/setup-python@v4 with: python-version: '3.8' - - uses: actions/cache@v2 + - uses: actions/cache@v3 with: path: ~/.cache/pip key: ${{ runner.os }}-pip-3.8 @@ -42,7 +42,7 @@ jobs: #---------------------------------------------- - name: Load cached venv id: cached-poetry-dependencies - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: .venv key: venv-${{ runner.os }}-${{ hashFiles('**/poetry.lock') }}-3.8 @@ -76,12 +76,12 @@ jobs: matrix: python-version: ['3.8'] steps: - - uses: actions/checkout@v2 + - uses: actions/checkout@master - name: Set up Python ${{ matrix.python-version }} - uses: actions/setup-python@v2 + uses: actions/setup-python@v3 with: python-version: ${{ matrix.python-version }} - - uses: actions/cache@v2 + - uses: actions/cache@v3 with: path: ~/.cache/pip key: ${{ runner.os }}-pip-${{ matrix.python-version }} @@ -102,7 +102,7 @@ jobs: #---------------------------------------------- - name: Load cached venv id: cached-poetry-dependencies - uses: actions/cache@v2 + uses: actions/cache@v3 with: path: .venv key: venv-${{ runner.os }}-${{ hashFiles('**/poetry.lock') }}-${{ matrix.python-version }} From 64fe9779522e5d0d67dbe654ca10cacc923e5e7c Mon Sep 17 00:00:00 2001 From: Jason Kai Date: Fri, 31 Mar 2023 14:36:03 -0400 Subject: [PATCH 3/3] Set modern-installation config option to false As of Poetry v1.4.1, packages were required to use modern installation (see: https://github.com/python-poetry/poetry/issues/7686). This is potentially problematic when relying on older versions of packages and for packages who are still using non-modern installers. This commit adds an additional step to disable that modern-installation requirement, which should get the workflow working again. --- .github/workflows/python-testing.yml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/.github/workflows/python-testing.yml b/.github/workflows/python-testing.yml index d248cbf7..0137ab6a 100644 --- a/.github/workflows/python-testing.yml +++ b/.github/workflows/python-testing.yml @@ -37,6 +37,10 @@ jobs: with: virtualenvs-create: true virtualenvs-in-project: true + - name: Disable Poetry modern installation + run: | + poetry config installer.modern-installation false + #---------------------------------------------- #---------------------------------------------- # load cached venv if cache exists #---------------------------------------------- @@ -97,6 +101,9 @@ jobs: with: virtualenvs-create: true virtualenvs-in-project: true + - name: Disable Poetry modern installation + run: | + poetry config installer.modern-installation false #---------------------------------------------- # load cached venv if cache exists #----------------------------------------------