Add CSS classes to ngx-contentful-richtext component and to renderers #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @kgajera , is the PR ok for you ? |
kgajera
reviewed
Jul 6, 2021
There was a problem hiding this comment.
Hi @Palapapaa! Thanks for this contribution.
I tested this out but I don't see how this will make it easier to add styling. For example, the changes in this PR would add classes like this:
<ngx-contentful-rich-text class="ngx-contentful-rich-text">
<p>
<ngx-contentful-rich-text class="ngx-contentful-rich-text">
<ng-component class="text-value">paragraph works!</ng-component>
</ngx-contentful-rich-text>
</p>
</ngx-contentful-rich-text>
So you could add styling like this:
.ngx-contentful-rich-text p {
font-weight: bold;
}
But how is that an improvement over adding styles without using classes:
ngx-contentful-rich-text p {
font-weight: bold;
}
kgajera
force-pushed
the
master
branch
2 times, most recently
from
f8b2e5e
to
38e3e9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
It adds a class name to
NgxContentfulRichTextComponentDefaultMarkRendererComponentTextValueComponentandDefaultNodeRendererComponent.I needed these class name for my project in order to add some custom CSS rules.
The class names may not be good, I can change this if needed.
Thank you =)