Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DayPicker Improvement #215

Closed
4 of 8 tasks
jossmac opened this issue Aug 13, 2018 · 9 comments
Closed
4 of 8 tasks

DayPicker Improvement #215

jossmac opened this issue Aug 13, 2018 · 9 comments
Assignees

Comments

@jossmac
Copy link
Member

jossmac commented Aug 13, 2018

The DayPicker component and corresponding CalendarDay field are basically functional, but require a bit more work to be complete:

Aesthetic

  • Moved to new issue: range-selection start/end day

Functionality

  • range-selection
  • selectable month from native <select/>
  • selectable year from native <select/>
  • unavailable/disabled days (greyed out)
  • select year by typing (if the list of available years is too long for a <select/>

A11y

  • keyboard navigation
  • screen-reader audit and subsequent updates

Ideas

  • i18n support for month/weekday labels
@jossmac jossmac self-assigned this Aug 13, 2018
@jesstelford
Copy link
Contributor

jesstelford commented Aug 13, 2018

Also:

  • Support in/not_in options. The UI for this could be a react-select with a custom dropdown that is a day picker, with the labels "One of", and "Not one of".

@molomby
Copy link
Member

molomby commented Aug 13, 2018

  • i18n support for different week start days (eg. Monday, Sunday, etc)

Note, for translated month/day labels we need full and abbreviated versions.

Also, I haven't played around with the UI but presumably the selected date text is displayed somewhere? It's format will need to be localised, obviously.

@molomby
Copy link
Member

molomby commented Aug 21, 2018

I'd say the most important thing here is being able to either:

  • Quickly navigate between years/decades, or..
  • Acting like a text field so users can enter a date

Entering my birthday currently takes 429 clicks 😱

@nathsimpson nathsimpson self-assigned this Aug 23, 2018
@nathsimpson
Copy link
Contributor

All of the month formatting has been made using a library that supports internationalisation (date-fns). Internationalisation is ready to go, it just needs to be parsed a locale :) The way this will be implemented would be part of a big-picture view on how Keystone will handle internationalisation.

@VinayaSathyanarayana
Copy link
Contributor

We need the option to turn off "Today" Button Ref #4499

@MadeByMike
Copy link
Contributor

@molomby can you add some notes about the bug with how the dates are stored?

@molomby
Copy link
Member

molomby commented Oct 24, 2019

@MadeByMike I don't have any problem with how CalendarDay values are stored; you might be thinking of my work on the DateTimeUtc type 🙂

@stale
Copy link

stale bot commented Feb 21, 2020

It looks like there hasn't been any activity here in over 6 months. Sorry about that! We've flagged this issue for special attention. It wil be manually reviewed by maintainers, not automatically closed. If you have any additional information please leave us a comment. It really helps! Thank you for you contribution. :)

@stale stale bot added the needs-review label Feb 21, 2020
@jossmac
Copy link
Member Author

jossmac commented Feb 21, 2020

React day picker should release version 8, which includes an improved API and hooks support, sometime soon. I'm happy to pick up this issues once that lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants