Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

setup travis #21

Closed
xgess opened this issue Sep 18, 2019 · 1 comment
Closed

setup travis #21

xgess opened this issue Sep 18, 2019 · 1 comment

Comments

@xgess
Copy link
Collaborator

xgess commented Sep 18, 2019

this project needs CI on travis. peek at make test to get started. and please either add mypy to it (it currently fails) or make a new issue just to get mypy passing and added.
@nathanmsmith
Copy link
Contributor

Re mypy: the main reason that doesn’t work is because dataclasses-json doesn’t have full typing support. (lidatong/dataclasses-json#23)

@nathanmsmith nathanmsmith mentioned this issue Nov 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xgess @nathanmsmith