You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
> @Victor-Schwan can you estimate how much work it would be to simply run the bash script in CI? If it's only a few more lines, I would appreciate it if it's added in this PR, otherwise, I am also fine with a follow up.
I took another look at the script and noticed two things:
I only use the nightlies for ILD@FCCee, hence, I cannot test the script easily with my detectors (I have never run it before). I suggest fixing the script and adding the CI in another PR
I took another look at the script and noticed two things:
IDEA
is hardcoded in a name (https://github.com/key4hep/k4geo/blob/main/scripts/check_material_budget.sh#L7). In my opinion, in the utils, scripts, etc, the detector choice should not be hardcoded/assumed; such a name can confuse.I only use the nightlies for ILD@FCCee, hence, I cannot test the script easily with my detectors (I have never run it before). I suggest fixing the script and adding the CI in another PR
Originally posted by @Victor-Schwan in #392 (comment)
The text was updated successfully, but these errors were encountered: