Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add running material plot scripts to CI #405

Open
tmadlener opened this issue Oct 24, 2024 · 0 comments
Open

Add running material plot scripts to CI #405

tmadlener opened this issue Oct 24, 2024 · 0 comments

Comments

@tmadlener
Copy link
Contributor

          > @Victor-Schwan can you estimate how much work it would be to simply run the bash script in CI? If it's only a few more lines, I would appreciate it if it's added in this PR, otherwise, I am also fine with a follow up.

I took another look at the script and noticed two things:

  1. According to a comment, for over a year it only runs on the stable key4hep release (https://github.com/key4hep/k4geo/blob/main/scripts/check_material_budget.sh#L57)
  2. In line 7, IDEA is hardcoded in a name (https://github.com/key4hep/k4geo/blob/main/scripts/check_material_budget.sh#L7). In my opinion, in the utils, scripts, etc, the detector choice should not be hardcoded/assumed; such a name can confuse.

I only use the nightlies for ILD@FCCee, hence, I cannot test the script easily with my detectors (I have never run it before). I suggest fixing the script and adding the CI in another PR

Originally posted by @Victor-Schwan in #392 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant