Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12 detector constructors defined in k4geo are not called from any compact file #377

Open
atolosadelgado opened this issue Aug 19, 2024 · 2 comments

Comments

@atolosadelgado
Copy link
Collaborator

Hi,

I was investigating where each detector constructor/factory/driver is used. Surprisingly, I found 12 detector constructors that are defined in k4geo but not called from any compact file.

FTD_Simple_Staggered
SiTrackerEndcap_o2_v02ext
SEcal04_Barrel_v01
ECalBarrel_o1_v02
Hcal_BarrelSD_v00
SEcal04_Endcaps_v01
CaloPrototype_v02
CaloPrototype_v03
PolyhedralBarrelSurfaces
GenericBarrelEnvelope
PolyhedralEndcapSurfaces
LumiCal_o1_v02

This bash script list the XML files that contain a reference to the corresponding detector constructor.
myscan.sh.txt

Here it is the list, in case you are curious :)
list_of_XML_for_each_detconstructor.txt

If you think this script can be useful, I can open a PR and put it in utils

@tmadlener
Copy link
Contributor

I have no strong opinion on the script, but we could consider starting some cleanup of unused detector constructors?

@andresailer
Copy link
Contributor

There might be users outside of k4geo hat use these builders. But we could add the deprecated_declare... to start with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants