Update README and Use Key4hep instead of Key4HEP #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-fila
reviewed
Oct 1, 2024
README.md
Outdated
| @@ -77,6 +77,8 @@ types of algorithms, depending on your use case: | |||
| - The `Transformer` is the more general one (both the `Consumer` and the | |||
| `Producer` are a particular case of this one) and takes both inputs and | |||
| outputs | |||
| - The `Filter`, for removing events from the events that are going to be | |||
There was a problem hiding this comment.
Suggested change
| - The `Filter`, for removing events from the events that are going to be | |
| - The `FilterPredicate`, for removing events from the events that are going to be |
There was a problem hiding this comment.
I think this explanation is a bit misleading since, the even will be marked to be filtered out only in the current branch of the workflow (and whether it's dropped there depends on the properties of the Sequencer/DecisionHub to which it belongs)
How about something like this:
for determining/controlling whether subsequent algorithms in the sequence are executed or bypassed
m-fila
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES