Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to filter MCParticles via generatorStatus #31

Closed
tmadlener opened this issue Jun 4, 2024 · 2 comments · Fixed by #27
Closed

Add possibility to filter MCParticles via generatorStatus #31

tmadlener opened this issue Jun 4, 2024 · 2 comments · Fixed by #27
Labels
enhancement New feature or request

Comments

@tmadlener
Copy link
Contributor

Similar to the simulator status it might be useful to filter on the generator status. This would allow it to filter out all the intermediate states that are present, e.g. during hadronization.

In this case the inputs are not as clear cut as for the simulation status, so we would probably need a list of input values to filter(?). Or potentially even the possibility for a user defined filter condition, based on the status value(?).

@tmadlener tmadlener added the enhancement New feature or request label Jun 4, 2024
@tmadlener tmadlener linked a pull request Jun 5, 2024 that will close this issue
@brauliorivas
Copy link
Member

So, to filter by generator status, does it have some special rules like simulator status?

we would probably need a list of input values to filter

Currently, the values are listed based on the data. It means it reads every particle and extract a set of unique values.

Or potentially even the possibility for a user defined filter condition, based on the status value(?).

Right now, the simplest way to filter by generator status is by checking if the particle genStatus is the same as in the filter. What else do you think that we could add?

@tmadlener
Copy link
Contributor Author

I was thinking about something like an expression, that can use the generatorStatus value, e.g. an input field, where I could put in something like

(generatorStatus !== 52) || (generatorStatus === 23)

I.e. something that is not easily possible with just the checkboxes. However, we could also wait with that until someone actually has a use case for this instead of pre-emptively implementing things that are not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants