Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a theme option #41

Open
pgroot91 opened this issue Apr 4, 2021 · 4 comments
Open

Add a theme option #41

pgroot91 opened this issue Apr 4, 2021 · 4 comments

Comments

@pgroot91
Copy link
Contributor

pgroot91 commented Apr 4, 2021

I added a theme option for my personal use and changed the CSS and smooshed it up a bit.
@pgroot91 pgroot91 mentioned this issue Apr 4, 2021
Merged
@Bozzified
Copy link

have an issue but something to think about. Not your fault. It's awesome ACF field. Just what I needed but I enqueue Font Awesome on admin side for some of my stuff and icons and it collides with it. Think about how to tackle this problem. I'll examine more but I disabled my font awesome on admin side to make your acf field work properly. Just a note about this.

@kevinruscoe
Copy link
Owner

@Bozzified does https://github.com/kevinruscoe/acf-star-rating-field/wiki/Cheat-Guide#upgrade-to-fa5-in-the-admin help?

@kevinruscoe
Copy link
Owner

To be honest, I think we could remove FA all together and just use SVGs, fixes a handfull of issues

@minimedj
Copy link

To be honest, I think we could remove FA all together and just use SVGs, fixes a handfull of issues

This is brilliant idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kevinruscoe @Bozzified @minimedj @pgroot91