-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMD module support #4
Comments
Thanks. I will upgrade to latest gl-matrix. Yes I need to add AMD support I have been poor doing that :) |
As soon as I have a little time if you haven't done it yet I might give it a try and send a pull request. ;) |
That would be great. I have found that gl-matrix have fixed quite a few bugs, some of which were affecting users - noticeably strange translation issues and quat->matrix - I will try and upgrade gl-matrix ASAP so it is easy to add AMD to rest of phoria scripts. |
I've been working on it but I found that due to the way the code is structured, it gets a little hairy to simply add the calls to |
OK I'd like to see the kind of refactoring that is need, so feel free to push it so I can take a look. |
Hi Kevin! |
I've been able to make Phoria work inside my AMD based workflow but only exploiting some quirks -- the culprit was mainly the bundled version of gl-matrix, actually, and its usage of global namespace; newer versions seem to have introduced AMD though and an upgrade should fix the issue. Anyway it would be awesome if you introduced support for AMD in Phoria.
Keep up the great work. :)
The text was updated successfully, but these errors were encountered: