Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scss fixes: year selector width, dropdown menu width, navbar refactoring #549

Merged
merged 1 commit into from
Feb 9, 2019
Merged

Conversation

infeeeee
Copy link
Contributor

@infeeeee infeeeee commented Feb 8, 2019

Description

Small scss fixes:

  • The width of the restart activities dropdown follows the content, checked on mobile, it's ok(max-width set)
  • Half of the last character of the time selector was hidden for me, now it doesn't cut that.
  • I also refractored the navbar.scss, so it more looks like a proper scss file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style
  • All files have a license header
  • All methods have a doc header with type declarations
  • I have updated the documentation accordingly
  • I have added tests to cover my changes

Copy link
Member

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly do you mean with

Half of the last character of the time selector was hidden for me, now it doesn't cut that.

I tried to reproduce it in Safari / Chrome / Firefox, but couldn't find it.
You meant years-selector and not time-selector, right?

@infeeeee
Copy link
Contributor Author

infeeeee commented Feb 9, 2019

It's on firefox 65 on linux. On windows, it was ok as well.

I created screenshots to demonstrate the problem: imgur. These images are from the demo install.
These images are from gnome on ubuntu, but on my main PC it's kde plasma on ubuntu, and the problem was the same.

I checked that this width:unset doesn't affect other browsers, so it solves this minor problem somehow

@kevinpapst
Copy link
Member

Okay, Firefox 65 here as well, but on Mac ... I'll test with a couple of browsers and merge afterwards.
Thanks 👍

@kevinpapst kevinpapst merged commit afb0eab into kimai:master Feb 9, 2019
@infeeeee infeeeee deleted the sass branch February 9, 2019 22:25
@lock
Copy link

lock bot commented Apr 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Apr 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants