Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to configured database version via ENV var #2055

Merged
merged 4 commits into from
Oct 24, 2020
Merged

Conversation

kevinpapst
Copy link
Member

Description

Without configured DATABASE_URL it was not possible to clear/warmup cache.

It could be faked by configuring a database url with version string:

DATABASE_URL=mysql://anonymous@localhost?serverVersion=mariadb-10.4.13

or now it can also be defined via the DATABASE_VERSION env var:

DATABASE_ENGINE=mysql
DATABASE_VERSION=mariadb-10.4.13

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.11 milestone Oct 24, 2020
@codecov
Copy link

codecov bot commented Oct 24, 2020

Codecov Report

Merging #2055 into master will increase coverage by 0.00%.
The diff coverage is 76.47%.

@@            Coverage Diff            @@
##             master    #2055   +/-   ##
=========================================
  Coverage     93.27%   93.27%           
- Complexity     5788     5790    +2     
=========================================
  Files           530      530           
  Lines         17538    17542    +4     
=========================================
+ Hits          16359    16363    +4     
  Misses         1179     1179           
Impacted Files Coverage Δ Complexity Δ
...endencyInjection/Compiler/DoctrineCompilerPass.php 76.59% <76.47%> (-0.15%) 22.00 <14.00> (+2.00) ⬇️
src/Repository/TimesheetRepository.php 89.54% <0.00%> (+0.19%) 133.00% <0.00%> (ø%)

@kevinpapst kevinpapst merged commit abd31e3 into master Oct 24, 2020
@kevinpapst kevinpapst deleted the dbversion-env branch October 24, 2020 19:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant