Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finnish translations #2046

Merged
merged 7 commits into from
Oct 25, 2020
Merged

Finnish translations #2046

merged 7 commits into from
Oct 25, 2020

Conversation

vilu85
Copy link
Contributor

@vilu85 vilu85 commented Oct 19, 2020

Description

Adds finnish translations for Kimai.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

Everything except invoice calculator, -renderer and -generator is now translated.
@kevinpapst
Copy link
Member

Thank you very much @vilu85 👍

I will have a look soon. Are you going to translate the latest files as well?

@vilu85
Copy link
Contributor Author

vilu85 commented Oct 20, 2020

Thank you very much @vilu85 👍

I will have a look soon. Are you going to translate the latest files as well?

Yes, I'll do that as soon as possible :)

@vilu85
Copy link
Contributor Author

vilu85 commented Oct 21, 2020

Thank you very much @vilu85 👍

I will have a look soon. Are you going to translate the latest files as well?

According to the translation documentation (https://www.kimai.org/documentation/translations.html) I don't need to translate frontend files app.js, calendar.js or moment.js. All files from kimai2/translations is now translated and checks have passed so this pull can be closed as soon as frontend files are upgraded.

@kevinpapst
Copy link
Member

kevinpapst commented Oct 21, 2020

Yes, sounds correct. I need to rebuild the frontend files with finnish being included.
Once this is done, I will deploy it to a demo and you can test it before merging.

Thanks 💯 times!

@kevinpapst
Copy link
Member

I changed my mind: I will merge it and you can check it directly on the official demo 😁

@kevinpapst kevinpapst added this to the 1.11 milestone Oct 25, 2020
@kevinpapst kevinpapst merged commit b9b7bf8 into kimai:master Oct 25, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants