Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explain limited access if project or customer has team permission #2006

Merged
merged 3 commits into from
Oct 1, 2020

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Sep 30, 2020

Description

Make sure that the user can identify that the current activity is not accessible to all users, if either its project or customer has teams permissions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst force-pushed the activity-permission branch from d42956b to 9e12cca Compare October 1, 2020 09:05
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #2006 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2006   +/-   ##
=========================================
  Coverage     93.38%   93.38%           
  Complexity     5461     5461           
=========================================
  Files           516      516           
  Lines         16762    16762           
=========================================
  Hits          15653    15653           
  Misses         1109     1109           
Impacted Files Coverage Δ Complexity Δ
src/Form/Toolbar/ActivityToolbarForm.php 100.00% <ø> (ø) 3.00 <0.00> (ø)

@kevinpapst kevinpapst merged commit 0aa6bae into master Oct 1, 2020
@kevinpapst kevinpapst deleted the activity-permission branch October 1, 2020 17:16
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant