Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix user-email validation #2004

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Fix user-email validation #2004

merged 3 commits into from
Sep 30, 2020

Conversation

kevinpapst
Copy link
Member

Description

Fixes #2003

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added the bug label Sep 30, 2020
@kevinpapst kevinpapst added this to the 1.11 milestone Sep 30, 2020
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #2004 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2004      +/-   ##
============================================
- Coverage     93.38%   93.37%   -0.01%     
  Complexity     5461     5461              
============================================
  Files           516      516              
  Lines         16762    16762              
============================================
- Hits          15653    15652       -1     
- Misses         1109     1110       +1     
Impacted Files Coverage Δ Complexity Δ
src/Form/UserCreateType.php 100.00% <ø> (ø) 3.00 <0.00> (ø)
src/Repository/TimesheetRepository.php 89.78% <0.00%> (-0.20%) 128.00% <0.00%> (ø%)

@kevinpapst kevinpapst merged commit de0a9f8 into master Sep 30, 2020
@kevinpapst kevinpapst deleted the fix-validation branch September 30, 2020 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing validation for duplicate email address and username
1 participant