Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ascending order for invoice items in command #1980

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

kevinpapst
Copy link
Member

Description

Fixes #1972

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.11 milestone Sep 18, 2020
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #1980 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1980   +/-   ##
=========================================
  Coverage     93.37%   93.37%           
  Complexity     5455     5455           
=========================================
  Files           516      516           
  Lines         16744    16745    +1     
=========================================
+ Hits          15634    15635    +1     
  Misses         1110     1110           
Impacted Files Coverage Δ Complexity Δ
src/Command/InvoiceCreateCommand.php 88.97% <ø> (+0.04%) 78.00 <0.00> (ø)

@kevinpapst kevinpapst merged commit 4cfa734 into master Sep 18, 2020
@kevinpapst kevinpapst deleted the invoice-command-order branch September 18, 2020 10:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invoice creation: Different ordering in web-interface compared to command line
1 participant