Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decrement invoice counter #1947

Merged
merged 4 commits into from
Sep 17, 2020
Merged

Decrement invoice counter #1947

merged 4 commits into from
Sep 17, 2020

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Sep 2, 2020

Description

  • fix increment for cc, ccy, ccn, ccd (increment was not possible before for these fields)
  • added decrement (for configs like {cy-5,3} - eg. when changing the invoice format during the year)
  • more tests
  • tests for undefined behavior (to document unclear points)
  • includes a BC break for undefined, unsupported & undocumented behavior (config like {cy+-1})

Documentation: kimai/www.kimai.org#75

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

- added decrement
- more tests
- tests for undefined behavior
- BC break for undefined behavior
@codecov
Copy link

codecov bot commented Sep 2, 2020

Codecov Report

Merging #1947 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1947   +/-   ##
=========================================
  Coverage     93.39%   93.39%           
- Complexity     5430     5437    +7     
=========================================
  Files           515      515           
  Lines         16663    16682   +19     
=========================================
+ Hits          15562    15580   +18     
- Misses         1101     1102    +1     
Impacted Files Coverage Δ Complexity Δ
...ce/NumberGenerator/ConfigurableNumberGenerator.php 97.93% <ø> (-0.78%) 32.00 <0.00> (+7.00) ⬇️

@kevinpapst kevinpapst changed the title Decrement invoice number Decrement invoice counter Sep 12, 2020
# Conflicts:
#	tests/Timesheet/DateTimeFactoryTest.php
@kevinpapst kevinpapst marked this pull request as ready for review September 17, 2020 00:52
@kevinpapst kevinpapst merged commit c02a882 into master Sep 17, 2020
@kevinpapst kevinpapst deleted the invoice-number-decrement branch September 17, 2020 00:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant