Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix in JS for project/activity selection in timesheet edit dialog #1894

Merged
merged 3 commits into from
Aug 16, 2020
Merged

Bugfix in JS for project/activity selection in timesheet edit dialog #1894

merged 3 commits into from
Aug 16, 2020

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Aug 16, 2020 •
edited
Loading

Description

Fixes #1809

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added the bug label Aug 16, 2020
@codecov
Copy link

codecov bot commented Aug 16, 2020

Codecov Report

Merging #1894 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1894   +/-   ##
=========================================
  Coverage     93.28%   93.28%           
  Complexity     5251     5251           
=========================================
  Files           493      493           
  Lines         16255    16255           
=========================================
  Hits          15164    15164           
  Misses         1091     1091

@kevinpapst kevinpapst mentioned this pull request Aug 16, 2020
Closed
@kevinpapst kevinpapst added this to the 1.10 milestone Aug 16, 2020
@kevinpapst kevinpapst marked this pull request as ready for review August 16, 2020 14:01
@kevinpapst kevinpapst changed the title Bug empty select Fixed a bug in the JS for project/activity selection in timesheet edit dialog Aug 16, 2020
@kevinpapst kevinpapst changed the title Fixed a bug in the JS for project/activity selection in timesheet edit dialog Bugfix in JS for project/activity selection in timesheet edit dialog Aug 16, 2020
@kevinpapst kevinpapst merged commit 4200208 into master Aug 16, 2020
@kevinpapst kevinpapst deleted the bug-empty-select branch August 16, 2020 14:20
pinedev pushed a commit to pinedevstudio/kimai2 that referenced this pull request Mar 23, 2021
@kevinpapst
Bugfix in JS for project/activity selection in timesheet edit dialog (k…
2bb7d96 
…imai#1894)
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.10
Development

Successfully merging this pull request may close these issues.

filter does not work
1 participant
@kevinpapst