Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign existing tag on timesheet import (#1877) #1883

Merged
merged 4 commits into from
Aug 12, 2020

Conversation

synaestic
Copy link
Contributor

Description

Fix for "Import timesheets using console fails to process tags #1877"

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1883 into master will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1883      +/-   ##
============================================
+ Coverage     92.89%   92.92%   +0.03%     
  Complexity     5206     5206              
============================================
  Files           490      490              
  Lines         16111    16111              
============================================
+ Hits          14966    14971       +5     
+ Misses         1145     1140       -5     
Impacted Files Coverage Δ Complexity Δ
src/Controller/ProjectController.php 91.47% <0.00%> (+2.24%) 55.00% <0.00%> (ø%)

Copy link
Member

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time @synaestic 👍 can you please have a look at that one comment of mine

src/Command/ImportTimesheetCommand.php Outdated Show resolved Hide resolved
@kevinpapst kevinpapst added the bug label Aug 12, 2020
@kevinpapst kevinpapst added this to the 1.10 milestone Aug 12, 2020
@kevinpapst kevinpapst merged commit dc9bc8a into kimai:master Aug 12, 2020
@kevinpapst
Copy link
Member

Thanks for your contribution @synaestic

Every help is always very welcome 😁

pinedev pushed a commit to pinedevstudio/kimai2 that referenced this pull request Mar 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants