Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some more tests #1835

Merged
merged 2 commits into from
Jul 21, 2020
Merged

added some more tests #1835

merged 2 commits into from
Jul 21, 2020

Conversation

kevinpapst
Copy link
Member

Description

  • added some missing unit tests
  • ignore AbstractMigration in Code Coverage, as it will be tested by the Migration runs (up and down) in CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.10 milestone Jul 21, 2020
@codecov
Copy link

codecov bot commented Jul 21, 2020

Codecov Report

Merging #1835 into master will increase coverage by 0.34%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1835      +/-   ##
============================================
+ Coverage     92.61%   92.95%   +0.34%     
+ Complexity     5161     5139      -22     
============================================
  Files           489      488       -1     
  Lines         15979    15937      -42     
============================================
+ Hits          14799    14815      +16     
+ Misses         1180     1122      -58     
Impacted Files Coverage Δ Complexity Δ
src/Saml/Provider/SamlProvider.php 100.00% <0.00%> (+14.28%) 6.00% <0.00%> (ø%)
src/Saml/SamlAuth.php 100.00% <0.00%> (+25.00%) 3.00% <0.00%> (ø%)
src/Saml/Controller/SamlController.php 78.26% <0.00%> (+52.17%) 9.00% <0.00%> (ø%)

@kevinpapst kevinpapst merged commit 4b8f743 into master Jul 21, 2020
@kevinpapst kevinpapst deleted the tests branch July 21, 2020 13:27
pinedev pushed a commit to pinedevstudio/kimai2 that referenced this pull request Mar 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant