Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added username to export #1827

Merged
merged 1 commit into from
Jul 17, 2020
Merged

added username to export #1827

merged 1 commit into from
Jul 17, 2020

Conversation

kevinpapst
Copy link
Member

Description

Fixes #1823

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@codecov
Copy link

codecov bot commented Jul 17, 2020

Codecov Report

Merging #1827 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1827   +/-   ##
=========================================
  Coverage     92.36%   92.37%           
- Complexity     5064     5068    +4     
=========================================
  Files           471      471           
  Lines         15670    15680   +10     
=========================================
+ Hits          14474    14484   +10     
  Misses         1196     1196           
Impacted Files Coverage Δ Complexity Δ
src/Export/Base/AbstractSpreadsheetRenderer.php 91.28% <100.00%> (+0.31%) 115.00 <0.00> (+4.00)

@kevinpapst kevinpapst merged commit 5864c7e into master Jul 17, 2020
@kevinpapst kevinpapst deleted the export-username branch July 17, 2020 00:32
pinedev pushed a commit to pinedevstudio/kimai2 that referenced this pull request Mar 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add username ID to timesheet export
1 participant