Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions #1803

Merged
merged 4 commits into from
Jul 4, 2020
Merged

Permissions #1803

merged 4 commits into from
Jul 4, 2020

Conversation

kevinpapst
Copy link
Member

Description

Code cleanup

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.10 milestone Jul 4, 2020
@codecov
Copy link

codecov bot commented Jul 4, 2020

Codecov Report

Merging #1803 into master will increase coverage by 0.00%.
The diff coverage is 92.30%.

@@            Coverage Diff            @@
##             master    #1803   +/-   ##
=========================================
  Coverage     92.32%   92.33%           
+ Complexity     4946     4941    -5     
=========================================
  Files           459      459           
  Lines         15306    15310    +4     
=========================================
+ Hits          14132    14136    +4     
  Misses         1174     1174           
Impacted Files Coverage Δ Complexity Δ
src/Entity/Activity.php 100.00% <ø> (ø) 31.00 <0.00> (ø)
src/Entity/Customer.php 100.00% <ø> (ø) 77.00 <0.00> (ø)
src/Entity/Project.php 100.00% <ø> (ø) 58.00 <0.00> (ø)
src/Entity/Timesheet.php 95.74% <ø> (ø) 74.00 <0.00> (ø)
...c/EventSubscriber/AjaxAuthenticationSubscriber.php 41.66% <0.00%> (ø) 6.00 <0.00> (ø)
src/Entity/User.php 98.40% <100.00%> (+0.05%) 72.00 <3.00> (+3.00)
src/Form/Type/TeamMemberType.php 80.95% <100.00%> (ø) 5.00 <0.00> (-1.00)
src/Repository/ActivityRepository.php 88.03% <100.00%> (ø) 48.00 <0.00> (-1.00)
src/Repository/CustomerRepository.php 94.38% <100.00%> (ø) 39.00 <0.00> (-1.00)
src/Repository/InvoiceRepository.php 69.62% <100.00%> (ø) 21.00 <0.00> (-1.00)
... and 4 more

@kevinpapst kevinpapst merged commit 682681a into master Jul 4, 2020
@kevinpapst kevinpapst deleted the permissions branch July 4, 2020 11:29
pinedev pushed a commit to pinedevstudio/kimai2 that referenced this pull request Mar 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant