Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoices: show only custom documents in upload form #1786

Merged
merged 8 commits into from
Jun 19, 2020
Merged

Conversation

kevinpapst
Copy link
Member

Description

See commits

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.10 milestone Jun 18, 2020
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #1786 into master will decrease coverage by 0.06%.
The diff coverage is 78.26%.

@@             Coverage Diff              @@
##             master    #1786      +/-   ##
============================================
- Coverage     92.37%   92.30%   -0.07%     
- Complexity     4871     4892      +21     
============================================
  Files           450      450              
  Lines         15087    15136      +49     
============================================
+ Hits          13936    13971      +35     
- Misses         1151     1165      +14     
Impacted Files Coverage Δ Complexity Δ
src/Form/InvoiceDocumentUploadForm.php 54.16% <21.42%> (-45.84%) 7.00 <5.00> (+5.00) ⬇️
src/Controller/InvoiceController.php 79.21% <86.66%> (+0.11%) 51.00 <0.00> (ø)
src/Repository/InvoiceDocumentRepository.php 94.23% <94.44%> (-5.77%) 26.00 <18.00> (+15.00) ⬇️
src/DependencyInjection/Configuration.php 98.30% <100.00%> (+<0.01%) 30.00 <0.00> (ø)
src/Invoice/ServiceInvoice.php 87.57% <100.00%> (+0.14%) 68.00 <2.00> (+1.00)

@kevinpapst kevinpapst merged commit 381f46c into master Jun 19, 2020
@kevinpapst kevinpapst deleted the invoices branch June 19, 2020 16:31
pinedev pushed a commit to pinedevstudio/kimai2 that referenced this pull request Mar 23, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant