Add color to tags #1631
Add color to tags #1631
Conversation
There was a problem hiding this comment.
Thanks for the PR @jojoemade !
Can you please execute composer kimai:codestyle-fix after applying the changes, that will fix the codestyle/linting issues.
The other test errors all come from the test database, which needs to updated with the migration.
But please don't do it yourself, I will test the changes and apply the migration later on.
jojoemade
force-pushed
the
feature/jojoemade/786
branch
from
aa60f50 to
566d703
Compare
Codecov Report
@@ Coverage Diff @@
## master #1631 +/- ##
=========================================
Coverage 92.17% 92.17%
Complexity 4774 4774
=========================================
Files 443 443
Lines 14785 14787 +2
=========================================
+ Hits 13628 13630 +2
Misses 1157 1157
|
|
|
||
| $this->assertInstanceOf(Tag::class, $sut->setColor('#fffccc')); | ||
| $this->assertEquals('#fffccc', $sut->getColor()); |
There was a problem hiding this comment.
Thanks for the addition!
Wouldn't it make more sense to test the trait just once instead of testing every place where it's used?
See https://phpunit.readthedocs.io/en/9.1/test-doubles.html#mocking-traits-and-abstract-classes
There was a problem hiding this comment.
I am not really testing that the method works as expected, but I rather want to make sure that the methods exists on the object.
|
Thanks @jojoemade really appreciate your contribution 👍 |
Description
A clear and concise description of what this pull request adds or changes.
Types of changes
Checklist
composer kimai:code-check)