Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added event before rendering permissions #1599

Merged
merged 5 commits into from
Mar 29, 2020
Merged

added event before rendering permissions #1599

merged 5 commits into from
Mar 29, 2020

Conversation

kevinpapst
Copy link
Member

Description

  • added event before rendering permissions

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.9 milestone Mar 29, 2020
@codecov
Copy link

codecov bot commented Mar 29, 2020

Codecov Report

Merging #1599 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #1599      +/-   ##
============================================
+ Coverage     92.08%   92.09%   +0.01%     
- Complexity     4701     4713      +12     
============================================
  Files           438      439       +1     
  Lines         14550    14573      +23     
============================================
+ Hits          13398    13421      +23     
  Misses         1152     1152              
Impacted Files Coverage Δ Complexity Δ
src/Controller/PermissionController.php 93.00% <100.00%> (+0.21%) 23.00 <0.00> (+1.00)
src/Event/PermissionsEvent.php 100.00% <100.00%> (ø) 11.00 <11.00> (?)

@kevinpapst kevinpapst merged commit 9e1e1a7 into master Mar 29, 2020
@kevinpapst kevinpapst deleted the events branch March 29, 2020 23:23
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant