Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to kimai specific user-bundle fork #1568

Merged
merged 2 commits into from
Mar 17, 2020
Merged

switch to kimai specific user-bundle fork #1568

merged 2 commits into from
Mar 17, 2020

Conversation

kevinpapst
Copy link
Member

Description

This PR replaces the FOSUserBundle with a Kimai fork, see https://github.com/kimai/user-bundle

This step was necessary as FOSUserBundle is neither recommended nor can be claimed a reliable and active project (even though some commits happen here and there). It wasn't tagged in more than 1,5 years and the Kimai composer package was pointing to master.

It ships a lot of unnecessary code (for Kimai), which can now be eliminated and one-by-one integrated into Kimai directly with a lot of new possibilities.

Finally the log gets cleaned up, as several outstanding deprecations can be fixed one after another (some already are).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.9 milestone Mar 17, 2020
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #1568 into master will not change coverage by %.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1568   +/-   ##
=========================================
  Coverage     92.09%   92.09%           
  Complexity     4570     4570           
=========================================
  Files           430      430           
  Lines         14107    14107           
=========================================
  Hits          12992    12992           
  Misses         1115     1115           

@kevinpapst kevinpapst merged commit 7b13ea8 into master Mar 17, 2020
@kevinpapst kevinpapst deleted the user-bundle branch March 17, 2020 20:24
@kevinpapst kevinpapst mentioned this pull request Mar 17, 2020
@jkabat
Copy link

jkabat commented Mar 18, 2020

@kevinpapst you may want to check out this repo.

I've got rid of FOS long time ago and used above replacement on several projects.

@kevinpapst
Copy link
Member Author

Thanks for the suggestion @jkabat
Thats the only repository I really considered, while I was searching for replacements.
Good to know that you already used it successful.

For now I wanted to have a solution that works fast with the least possible work 😁 but when I will do a real refactoring on that part I will try it.

@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants