Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline css for html invoices #1526

Merged
merged 7 commits into from
Mar 6, 2020
Merged

inline css for html invoices #1526

merged 7 commits into from
Mar 6, 2020

Conversation

kevinpapst
Copy link
Member

Description

Allows to save a HTML invoice revision safe, as no external resources are linked.
All styles are inlined now.

Invoice styles were removed from the general "app" css, which could be a potential BC break if somebody relied on it in their own invoice templates.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #1526 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##             master    #1526   +/-   ##
=========================================
  Coverage     92.61%   92.62%           
- Complexity     4351     4356    +5     
=========================================
  Files           421      422    +1     
  Lines         13503    13517   +14     
=========================================
+ Hits          12506    12520   +14     
  Misses          997      997           
Impacted Files Coverage Δ Complexity Δ
src/Twig/EncoreExtension.php 100.00% <0.00%> (ø) 5.00% <0.00%> (?%)

# Conflicts:
#	public/build/app.761d11cb.css
#	public/build/entrypoints.json
#	public/build/manifest.json
@kevinpapst kevinpapst merged commit a50a59b into master Mar 6, 2020
@kevinpapst kevinpapst deleted the invoice-inline-css branch March 6, 2020 02:21
@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant