Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications by SweetAlert2 #1508

Merged
merged 9 commits into from
Oct 2, 2020
Merged

Notifications by SweetAlert2 #1508

merged 9 commits into from
Oct 2, 2020

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Feb 29, 2020

Description

Currently Kimai uses two ways of showing user feedback:

  • SweetAlert2 mostly for API and AJAX calls
  • In page errors and success messages after form submission

This PR changes that behavior: all notifications will be rendered by SweetAlert => no more "jumping pages".

Open question
sweetalert2 cannot display multiple messages at once => how should that be handled?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added the needs discussion requisition comments from the community to find a solution that fits all label Apr 19, 2020
# Conflicts:
#	public/build/app.e3ecc7d6.js
#	public/build/entrypoints.json
#	public/build/manifest.json
#	translations/flashmessages.de.xlf
#	translations/flashmessages.en.xlf
@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #1508 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1508      +/-   ##
============================================
- Coverage     93.38%   93.32%   -0.06%     
- Complexity     5461     5465       +4     
============================================
  Files           516      516              
  Lines         16762    16772      +10     
============================================
  Hits          15653    15653              
- Misses         1109     1119      +10     
Impacted Files Coverage Δ Complexity Δ
src/Controller/AboutController.php 61.53% <ø> (-5.13%) 4.00 <0.00> (ø)
src/Controller/AbstractController.php 64.86% <ø> (-20.85%) 18.00 <0.00> (+4.00) ⬇️
src/Controller/ActivityController.php 92.44% <ø> (ø) 42.00 <0.00> (ø)
src/Controller/CustomerController.php 91.24% <ø> (ø) 52.00 <0.00> (ø)
src/Controller/HomepageController.php 76.19% <ø> (-3.81%) 5.00 <0.00> (ø)
src/Controller/InvoiceController.php 79.88% <ø> (+0.45%) 52.00 <0.00> (ø)
src/Controller/PermissionController.php 92.72% <ø> (ø) 27.00 <0.00> (ø)
src/Controller/ProjectController.php 91.47% <ø> (ø) 55.00 <0.00> (ø)
src/Controller/SystemConfigurationController.php 98.57% <ø> (ø) 22.00 <0.00> (ø)
src/Controller/TagController.php 89.23% <ø> (ø) 16.00 <0.00> (ø)
... and 9 more

@kevinpapst kevinpapst marked this pull request as ready for review September 30, 2020 18:30
@kevinpapst kevinpapst added help wanted needs a developer who want to add this feature and removed needs discussion requisition comments from the community to find a solution that fits all labels Sep 30, 2020
@kevinpapst kevinpapst added this to the 1.11 milestone Sep 30, 2020
@kevinpapst kevinpapst merged commit 825e492 into master Oct 2, 2020
@kevinpapst kevinpapst deleted the flashmessages-sweetalert2 branch October 2, 2020 17:37
@kevinpapst kevinpapst added feature request and removed help wanted needs a developer who want to add this feature labels Oct 26, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant