Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added project importer and grandtotal converter #1468

Merged
merged 38 commits into from
Oct 11, 2020
Merged

added project importer and grandtotal converter #1468

merged 38 commits into from
Oct 11, 2020

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Feb 13, 2020

Description

  • Restructured importer for better code extensions
  • Added a GrandTotal customer importer
  • Added a real project importer
  • Added a pure customer importer

TODO:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.8 milestone Feb 13, 2020
@kevinpapst kevinpapst removed this from the 1.8 milestone Feb 29, 2020
@kevinpapst kevinpapst changed the title added customer importer and grandtotal converter added project importer and grandtotal converter Oct 8, 2020
@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #1468 into master will increase coverage by 0.14%.
The diff coverage is 98.01%.

@@             Coverage Diff              @@
##             master    #1468      +/-   ##
============================================
+ Coverage     93.30%   93.44%   +0.14%     
- Complexity     5472     5747     +275     
============================================
  Files           518      530      +12     
  Lines         16808    17457     +649     
============================================
+ Hits          15682    16313     +631     
- Misses         1126     1144      +18     
Impacted Files Coverage Δ Complexity Δ
src/Configuration/FormConfiguration.php 100.00% <ø> (ø) 11.00 <0.00> (ø)
src/Importer/AbstractCustomerImporter.php 94.87% <94.87%> (ø) 22.00 <22.00> (?)
src/Command/ImportProjectCommand.php 94.91% <94.91%> (ø) 26.00 <26.00> (?)
src/Command/ImportCustomerCommand.php 94.93% <95.45%> (ø) 17.00 <1.00> (?)
src/Importer/AbstractProjectImporter.php 98.30% <98.30%> (ø) 29.00 <29.00> (?)
src/Importer/GrandtotalCustomerImporter.php 98.94% <98.94%> (ø) 55.00 <55.00> (?)
src/API/UserController.php 100.00% <100.00%> (ø) 16.00 <1.00> (ø)
src/Configuration/SystemConfiguration.php 100.00% <100.00%> (ø) 26.00 <10.00> (+10.00)
src/Controller/ActivityController.php 91.42% <100.00%> (ø) 42.00 <1.00> (ø)
src/Controller/CustomerController.php 91.24% <100.00%> (ø) 52.00 <2.00> (ø)
... and 27 more

@kevinpapst kevinpapst marked this pull request as ready for review October 11, 2020 14:25
@kevinpapst kevinpapst added this to the 1.11 milestone Oct 11, 2020
@kevinpapst kevinpapst merged commit 996f05c into master Oct 11, 2020
@kevinpapst kevinpapst deleted the importer branch October 11, 2020 20:08
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant