Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the back link appear like a normal link instead of a button #139

Merged
merged 1 commit into from
Feb 18, 2018

Conversation

simonschaufi
Copy link
Contributor

Description

Give the back link just a link class instead of warning

Types of changes

  • UI

Copy link
Member

@kevinpapst kevinpapst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"annoying" is quite a personal perception...

I'm fine changing it, but "btn-link" is not a valid class. Please use "btn-default" as seen on https://adminlte.io/themes/AdminLTE/pages/UI/buttons.html

And adjust the _form_delete.html.twig as well please.

@simonschaufi
Copy link
Contributor Author

As the template is based on bootstrap, btn-link is a valid class. You can also inpect the element and see that there is css available for it.

@kevinpapst
Copy link
Member

Okay, I just checked the link and tried it, but it doesn't look like a button anymore (to me: more distracting than before). Thats why I proposed the other class, so it look like a button but is not so prominently highlighted

@simonschaufi
Copy link
Contributor Author

Thats exactly what the link should look like: Like a link and not like a button: https://getbootstrap.com/docs/3.3/css/#buttons-options

@simonschaufi simonschaufi changed the title Make the back link less annoying Make the back link appear like a normal link instead of a button Feb 16, 2018
@kevinpapst
Copy link
Member

I checked a couple of other tools and there seems to be no real UX guide on how a back/cancel button should look like.
But you are right, here it’s a navigational element.

@simonschaufi simonschaufi merged commit 4af0e27 into master Feb 18, 2018
@simonschaufi simonschaufi deleted the back-link branch February 18, 2018 11:12
@kevinpapst kevinpapst added this to the 0.2 milestone Jun 23, 2018
@lock
Copy link

lock bot commented Nov 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants