Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duration field in timesheet edit dialog #1180

Merged
merged 8 commits into from
Oct 24, 2019
Merged

duration field in timesheet edit dialog #1180

merged 8 commits into from
Oct 24, 2019

Conversation

kevinpapst
Copy link
Member

Description

Added. duration field to the timesheet dialog.

Can be tested at https://demo-branch.kimai.org/en/timesheet/

Also adds a "now" button to the calendar icon, fixes #844

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst
Copy link
Member Author

kevinpapst commented Oct 24, 2019

ping @hmr-it-jr @yayitazale could you have a look if that works as expected? You voted for the now button, this PR includes the now button (hidden behind the blue icon) and also a new duration field + dependencies between begin and end field, to make your life a little bit easier (hopefully) 😀

Bildschirmfoto 2019-10-24 um 17 00 47

@yayitazale
Copy link
Contributor

Is this on the dev version of the demo? I can't see it...

@kevinpapst
Copy link
Member Author

Sorry 😁 link was in the initial post, here you go: https://demo-branch.kimai.org/en/timesheet/

@yayitazale
Copy link
Contributor

Works like a charm.

Thank you.

@kevinpapst kevinpapst merged commit 1114538 into master Oct 24, 2019
@kevinpapst kevinpapst deleted the duration-field branch October 24, 2019 21:46
@lock
Copy link

lock bot commented Dec 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "now" button to manual timesheet entry
2 participants