Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phpunit 8 #1155

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Phpunit 8 #1155

merged 2 commits into from
Oct 24, 2019

Conversation

kevinpapst
Copy link
Member

Description

Upgrade to PHPUnit 8

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.4 milestone Oct 3, 2019
@codecov
Copy link

codecov bot commented Oct 3, 2019

Codecov Report

Merging #1155 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master    #1155      +/-   ##
============================================
+ Coverage     92.87%   92.91%   +0.04%     
+ Complexity     3333     3326       -7     
============================================
  Files           332      332              
  Lines         10327    10315      -12     
============================================
- Hits           9591     9584       -7     
+ Misses          736      731       -5
Impacted Files Coverage Δ Complexity Δ
src/API/ActivityController.php 97.53% <ø> (ø) 21 <0> (ø) ⬇️
src/Form/TimesheetEditForm.php 86.53% <ø> (ø) 55 <0> (ø) ⬇️
src/EventSubscriber/TimezoneSubscriber.php 94.11% <ø> (ø) 7 <0> (ø) ⬇️
src/Validator/Constraints/TimesheetValidator.php 96.51% <ø> (ø) 31 <0> (ø) ⬇️
src/API/TimesheetController.php 96.42% <ø> (ø) 68 <0> (ø) ⬇️
src/Repository/Query/VisibilityQuery.php 100% <ø> (+11.11%) 3 <0> (-2) ⬇️
src/API/TeamController.php 100% <ø> (ø) 6 <0> (ø) ⬇️
src/API/CustomerController.php 98.68% <ø> (ø) 18 <0> (ø) ⬇️
src/Doctrine/UTCDateTimeType.php 100% <ø> (ø) 9 <0> (ø) ⬇️
src/EventSubscriber/UserPreferenceSubscriber.php 100% <ø> (+2.46%) 15 <0> (-3) ⬇️
... and 9 more

@kevinpapst kevinpapst modified the milestones: 1.4, 1.5 Oct 4, 2019
@kevinpapst kevinpapst merged commit b0f8329 into master Oct 24, 2019
@kevinpapst kevinpapst deleted the phpunit-8 branch October 24, 2019 15:35
@lock
Copy link

lock bot commented Dec 23, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Dec 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant