Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix search dropdown #1142

Merged
merged 12 commits into from
Sep 25, 2019
Merged

Fix search dropdown #1142

merged 12 commits into from
Sep 25, 2019

Conversation

kevinpapst
Copy link
Member

@kevinpapst kevinpapst commented Sep 24, 2019

Description

Fixes #1112

Can be tested at: https://demo-branch.kimai.org/

One open issue is left: when deleting a choice from a multi-select (eg. users list) then the dropdown is closed and the list stays open. I am still looking for a fix...

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I verified that my code applies to the guidelines (composer kimai:code-check)
  • I updated the documentation (see here)
  • I agree that this code is used in Kimai and will be published under the MIT license

@kevinpapst kevinpapst added this to the 1.4 milestone Sep 24, 2019
@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #1142 into master will decrease coverage by 0.1%.
The diff coverage is 23.07%.

@@             Coverage Diff              @@
##             master    #1142      +/-   ##
============================================
- Coverage     93.19%   93.09%   -0.11%     
- Complexity     3242     3246       +4     
============================================
  Files           324      326       +2     
  Lines         10088    10094       +6     
============================================
- Hits           9402     9397       -5     
- Misses          686      697      +11
Impacted Files Coverage Δ Complexity Δ
src/Form/Toolbar/InvoiceToolbarForm.php 100% <ø> (ø) 3 <0> (-1) ⬇️
src/Form/Toolbar/ExportToolbarForm.php 100% <ø> (ø) 3 <0> (-1) ⬇️
src/Form/Toolbar/ActivityToolbarForm.php 100% <ø> (ø) 2 <0> (ø) ⬇️
src/Repository/TagRepository.php 90% <0%> (-6.43%) 14 <1> (+1)
src/Form/Toolbar/AbstractToolbarForm.php 91.95% <0%> (-2.84%) 28 <1> (ø)
src/Form/Type/TagsSelectType.php 0% <0%> (ø) 2 <2> (?)
src/Repository/Query/TagFormTypeQuery.php 100% <100%> (ø) 3 <3> (?)
src/DependencyInjection/Configuration.php 98.8% <100%> (ø) 23 <0> (ø) ⬇️
src/Form/Extension/EnhancedChoiceTypeExtension.php 83.33% <0%> (-5.56%) 8% <0%> (ø)
... and 4 more

@kevinpapst kevinpapst merged commit d661c8b into master Sep 25, 2019
@kevinpapst kevinpapst deleted the fix-dropdown branch September 25, 2019 16:34
@lock
Copy link

lock bot commented Nov 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent search from getting closed on each selection
1 participant