Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editing translation not visible #1546

Closed
ateliernz opened this issue Mar 12, 2020 · 15 comments
Closed

editing translation not visible #1546

ateliernz opened this issue Mar 12, 2020 · 15 comments

Comments

@ateliernz
Copy link

Question: I edited /translations/messages.nl.xlf

I cleared cache. I ran bin/console lint:xliff translations to validate - a lot of errors, but not for my file.

However, I don't see any changes. I think I do something wrong.

@kevinpapst
Copy link
Member

a lot of errors, but not for my file.

What errors?

@ateliernz
Copy link
Author

for all .xliff-files:
ERROR in translations/invoice-numbergenerator.da.xliff

  • There is a mismatch between the language included in the file name ("invoice-numbergenerator.da.xliff") and the "da" value used in the "target-language" attribute of the file.

@kevinpapst
Copy link
Member

Can you upgrade to the latest Kimai version? That error does not exist here.

@ateliernz
Copy link
Author

last time i tried upgrading from 1.6.2 to 1.7 went wrong. It's not really easy to do from command line if you're not used to like me. I got some errors and I couldn't fix it/understand it, so I put the folders and files back from backup and it works now.

Installing also wasn't easy on a Synology NAS. Trick was to install php7.2 on Synology, install composer.phar in the kimai2 folder via command line and run sudo php72 composer.phar instead of composer commands.

@kevinpapst
Copy link
Member

Do you know that article: https://www.kimai.org/documentation/synology.html#updating-kimai

But back to topic: translation files should be reloaded when the cache was cleared.
Without seeing the file, I cannot help.

@ateliernz
Copy link
Author

Never found it, but that looks promising!

I guess: first update, then, if still existing, shoot this issue again?

@kevinpapst
Copy link
Member

Its your system ... at some point an upgrade should be done.
I could have a look at the translation file anyways, but need to know what you changed.

@ateliernz
Copy link
Author

ateliernz commented Mar 12, 2020

Well, I copied the nl file for backup and edited the original like this
[edit: because the dutch translation looks like flemish, I needed a dutch-dutch version. eventually, i want to make a language variant nl-NL . Now I know how it feels to be the 'variant' instead of the general language!]

@kevinpapst
Copy link
Member

hahaha ... but actually NL should be nl_NL and not nl_BE or whatever the code for flemish is.
Inviting @1willem into the discussion.
And I cannot download the file, always run into a timeout. Please attach it in your post

@ateliernz
Copy link
Author

this

@kevinpapst
Copy link
Member

Works fine on my end. Just copied the file to my installation and I see e.g. "Mijn uren" as label for the timesheet menu

@ateliernz
Copy link
Author

Thanks for testing. This issue can be closed. First I need to update my installation

@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

2 similar comments
@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock
Copy link

lock bot commented May 20, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants