Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent search from getting closed on each selection #1112

Closed
rarvin opened this issue Sep 16, 2019 · 10 comments · Fixed by #1142
Closed

Prevent search from getting closed on each selection #1112

rarvin opened this issue Sep 16, 2019 · 10 comments · Fixed by #1142
Labels
Milestone

Comments

@rarvin
Copy link

rarvin commented Sep 16, 2019

The new global search option is quiet useful, but once it opens - for each selection the screen closes automatically and one has to again click on the search bar to reopen the search screen and then choose the next selection item, this needs to be repeated for each selection since the screen closes each time. If the search screen window stays open till the entire selection is completed by the user it would help in terms of user experience.
Screenshot_20190916_130731

@rarvin
Copy link
Author

rarvin commented Sep 16, 2019

Just to update this issue is seen only when the javascript (select-boxes in forms) option is chosen. The screens dont close with the non-javascript option.

@JayAige
Copy link

JayAige commented Sep 16, 2019

In addition: The search screen remains when javascript option is not used for all fields except 'time range'. When I select a specific time range, the screen closes and I have to reopen it.

@SerjBondarenko
Copy link

I'm joining. I have the same issue.

@kevinpapst
Copy link
Member

If you would know how much time I already spent with that damn javascript select component ...
Honestly: I spent probably 10 hours trying top fix it. Seems not possible, there is a technical limitation I cannot get around.

There is just one thing that I did not try yet. If that doesn't work there are only two options:

  • completely change the UI of that search/filter dropdown
  • disable the JS component for the filters

@kevinpapst kevinpapst added the bug label Sep 18, 2019
@rarvin
Copy link
Author

rarvin commented Sep 18, 2019 via email

@kevinpapst kevinpapst mentioned this issue Sep 24, 2019
4 tasks
@kevinpapst
Copy link
Member

I replaced the JS component which was used. You shouldn't notice the difference in behavior, just the look is slightly different.
Can you please re-test this at: https://demo-branch.kimai.org

@JayAige
Copy link

JayAige commented Sep 24, 2019

Works perfect for me. Thank you very much!

@kevinpapst kevinpapst added this to the 1.4 milestone Sep 24, 2019
@rarvin
Copy link
Author

rarvin commented Sep 25, 2019 via email

@SerjBondarenko
Copy link

Very good, thank you.

@lock
Copy link

lock bot commented Nov 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. If you use Kimai on a daily basis, please consider donating to support further development of Kimai.

@lock lock bot locked and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants