From 73892bac7bce2243f0742aaf343d1116aec7baad Mon Sep 17 00:00:00 2001 From: Kevin Locke Date: Wed, 27 Oct 2021 11:00:30 -0600 Subject: [PATCH] Remove --strict-peer-deps from npm install in CI Since it causes npm install to fail with ERESOLVE on npm@^7.20.3 or npm@>=8.0.0 <8.1.1 due to the combination of eslint@^7.0.0 and eslint-plugin-node@^11.0.0: https://github.com/npm/cli/issues/3868#issuecomment-939367333 Rather than updating npm on the runner during each CI run, remove --strict-peer-deps until a version of Node.js ships with npm@^8.1.1. Signed-off-by: Kevin Locke --- .github/workflows/node.js.yml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index 6da9bad..a4e3c7f 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -40,7 +40,9 @@ jobs: - name: Display Node.js version run: node --version - name: Install dependencies - run: npm install --strict-peer-deps + # Note: Not using --strict-peer-deps until npm@8.1.1 ships with Node.js + # due to https://github.com/npm/cli/issues/3868 + run: npm install - name: Lint run: npm run lint - name: Run tests @@ -98,7 +100,9 @@ jobs: - name: Display Node.js version run: node --version - name: Install dependencies - run: npm install --strict-peer-deps + # Note: Not using --strict-peer-deps until npm@8.1.1 ships with Node.js + # due to https://github.com/npm/cli/issues/3868 + run: npm install - name: Run tests run: npm run test-unit-cov # Note: Not uploading to Codecov, due to poor support for matrix builds