Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth-cas error after upgrade to osTicket Version v1.17-rc4 #35

Closed
pwhawley opened this issue Sep 18, 2022 · 4 comments
Closed

auth-cas error after upgrade to osTicket Version v1.17-rc4 #35

pwhawley opened this issue Sep 18, 2022 · 4 comments

Comments

@pwhawley
Copy link

Hello, I receive the following error when enabling CAS authentication plugin after upgrading to OSTicket v1.17rc4.

Fatal error: Cannot redeclare non static AuthenticationBackend::$config as static CasStaffAuthBackend::$config in phar://C:/include/plugins/auth-cas.phar/cas.php on line 243

Environment:
Windows Server 2012 R2
osTicket Version | v1.17-rc4 (356e156)  
Web Server Software | Microsoft-IIS/8.5
MySQL Version | 8.0.20
PHP Version | 8.0.22

JASIG CAS Authentication | 1.2.1

@tauthement
Copy link

tauthement commented Oct 5, 2022

I'm getting the same error with the 1.17 release.

osTicket Version | 1.17-git (34c64f14)  
Web Server Software | Apache
MySQL Version | 10.5.17
PHP Version | 8.0.23

@larueli
Copy link
Contributor

larueli commented Nov 18, 2022

I also got this issue.

It appears that implementing the multi-instance feature of osTicket led to this commit : osTicket/osTicket@0b93b48.

It created a protected non static attribute config for the class AuthenticationBackend

https://github.com/osTicket/osTicket/blob/0b93b48ec6c821e9f182ab2a830ca0adcf24138a/include/class.auth.php#L180

This new attribute being protected is given to all derivated classes, including StaffAuthenticationBackend, then ExternalStaffAuthenticationBackend, and ultimately to our plugin CasStaffAuthBackend class which declares since 7 years a private and static config attribute and now conflicts with osTicket source code.

private static $config;

I'm trying to work on a fix.

@larueli
Copy link
Contributor

larueli commented Nov 18, 2022

Found a fix, preparing a PR for it.

@tauthement
Copy link

tauthement commented Nov 18, 2022

Thanks for looking into that. I went ahead and switched to the OAuth plugin for authentication since my IDP (WSO2) supports it. It works well, but lacks as much attribute mapping that I can do with this plugin. Hopefully this plugin gets an update for those that still use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants