Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

feat: splash screen support #6

Merged
merged 3 commits into from
May 31, 2022
Merged

feat: splash screen support #6

merged 3 commits into from
May 31, 2022

Conversation

kevinmarrec
Copy link
Owner

@kevinmarrec kevinmarrec commented May 30, 2022

Follows @xlanex6 work (#4)
Resolves #3

This PR will be squashed and merged with the following commit description to keep credits on @xlanex6 :

Co-authored-by: Alex Duval <[email protected]>

@kevinmarrec kevinmarrec self-assigned this May 30, 2022
@kevinmarrec kevinmarrec changed the title splash screen support (#4) feat: splash screen support May 30, 2022
@kevinmarrec kevinmarrec added the enhancement New feature or request label May 30, 2022
@kevinmarrec kevinmarrec modified the milestone: v0.2.0 May 30, 2022
@kevinmarrec kevinmarrec marked this pull request as ready for review May 30, 2022 16:48
@kevinmarrec
Copy link
Owner Author

kevinmarrec commented May 30, 2022

@xlanex6 You can check my changes, I think it's ready. I finally added back the splash.backgroundColor option, as well as targetDir (default: splash).

You can have a try and give your feedback :)

Also don't hesitate to ask anything regarding my changes.

EDIT: I also added tests that check splash screens are correctly generated.

@xlanex6
Copy link
Contributor

xlanex6 commented May 31, 2022

@kevinmarrec
Funny that you back to my initial idea to make a root options splash with all options into.
You make it better way than I could. thank you

@kevinmarrec
Copy link
Owner Author

@xlanex6 Yeah I got confused with some of my thoughts at some point. You had it in the good direction mate 👍

@xlanex6
Copy link
Contributor

xlanex6 commented May 31, 2022

@kevinmarrec

Are you plan to make a DOC site , with exemple , video demo to explain How it works , etc...
If so , and still possible , I will love to be part of it.

@kevinmarrec
Copy link
Owner Author

@xlanex6 I don't think I'll make one, because overall it will land in https://github.com/nuxt-community/pwa-module as official module. I'm working at NuxtLabs so it will be just about time that things get more official. Therefore the documentation will be on the official module :)

@kevinmarrec kevinmarrec merged commit 970c5f8 into main May 31, 2022
@kevinmarrec kevinmarrec deleted the splash branch May 31, 2022 07:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS Splash Screen Generator
2 participants