Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

support of crossorigin="use-credentials" for basic auth #57

Closed
flkrnr opened this issue Oct 21, 2022 · 2 comments · Fixed by #87
Closed

support of crossorigin="use-credentials" for basic auth #57

flkrnr opened this issue Oct 21, 2022 · 2 comments · Fixed by #87
Milestone

Comments

@flkrnr
Copy link

flkrnr commented Oct 21, 2022

Thanks for your awesome work so far!

It would be great if we could have support for applications behind basic auth.

I think this should be possible by simply adding crossorigin: 'use-credentials' to the manifest.json link:

pwa._manifestMeta = {
rel: 'manifest',
href: joinURL(nuxt.options.app.baseURL, 'manifest.json'),
}

(Souce: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/crossorigin)

as far as i can tell it is possible in the pwa-module for nuxt2. (https://pwa.nuxtjs.org/workbox#basic-auth)
(nuxt-community/pwa-module#94 (comment))

relates to #54

@flkrnr flkrnr changed the title support of crossorigin="use-credentials" support of crossorigin="use-credentials" for basic auth Oct 21, 2022
@kevinmarrec
Copy link
Owner

Closed by #55

Will be available in next release

@kevinmarrec kevinmarrec added this to the v0.9.0 milestone Oct 22, 2022
@flkrnr
Copy link
Author

flkrnr commented Nov 4, 2022

@kevinmarrec i think this needs to be implemented as well when loading the manifest.json (see my reference) #55 just adds interface definitions for other properties but not the property crossorigin nor the actual implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants