Skip to content
This repository has been archived by the owner on May 2, 2024. It is now read-only.

Improve icon generation to reduce cutoff #44

Closed
TheAlexLichter opened this issue Oct 1, 2022 · 5 comments
Closed

Improve icon generation to reduce cutoff #44

TheAlexLichter opened this issue Oct 1, 2022 · 5 comments

Comments

@TheAlexLichter
Copy link
Contributor

TheAlexLichter commented Oct 1, 2022

Follow-up of #40
Thanks to 8c1f8e2, the generation is running through now but the icon is cut off when height > width.

It'd be ideal to termine whether height > width, then running sharp(input).resize(undefined, Math.floor(size)) and else running ``sharp(input).resize(Math.floor(size))`


Result with current state:

grafik

Result with (harcoded) patch:

grafik

@kevinmarrec
Copy link
Owner

Yeah I didn't know what to do regarding not squared icons, if undefined on resize function works well I'm gonna do adjustments.

Thanks for feedback !

@kevinmarrec
Copy link
Owner

@manniL Could you provide the image you used please ? 💚

@TheAlexLichter
Copy link
Contributor Author

Sure! https://gubutler.com/icon.png

@kevinmarrec
Copy link
Owner

kevinmarrec commented Oct 1, 2022

@manniL Thanks, I found a better way to handle it, and also made splashs working with all icon sizes !

Closing through f342fa8

Released in v0.6.1

@TheAlexLichter
Copy link
Contributor Author

Awesome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants