Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Laravel 7 support #323

Closed
schonhose opened this issue Apr 27, 2020 · 9 comments
Closed

Add Laravel 7 support #323

schonhose opened this issue Apr 27, 2020 · 9 comments

Comments

@schonhose
Copy link

Hi Kevin,
Could you update composer.json to support Laravel 7 as well?
Thanks

@kevinkhill
Copy link
Owner

kevinkhill commented May 4, 2020

What needs to be changed? Lavacharts is framework agnostic, so technically it already can be used? Are the Laravel specific features not working?

(I haven't been in PHP land a while, the last Laravel release I was excited about included auto-discovery for packages)

@arungpisyadi
Copy link

Hello @kevinkhill

It creates this error:
"Deprecation Notice: Class Khill\Lavacharts\Support\RenderableTrait located in [Root Folder]/vendor/khill/lavacharts/src\Support\Renderable.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar://C:/ProgramData/ComposerSetup/bin/composer.phar/src/Composer/Autoload/ClassMapGenerator.php:201"

Do you have any suggestions to workaround it?

@kevinkhill
Copy link
Owner

I fiiiiiiiiiinally downloaded L7 and linked my local copy of Lavacharts...

now we blowing off the cobwebs.... do some dusting....

No issue so far with L7 and Lavacharts 3.1, just made a quick PieChart

We'll track the progress of Composer 2.0 testing with this issue

@jackwh
Copy link

jackwh commented Nov 10, 2020

Hi! Any updates on this issue please?

Laravel is now up to version 8, and Composer 2.0 has been out for some time.

@kevinkhill
Copy link
Owner

kevinkhill commented Nov 10, 2020 via email

@schonhose
Copy link
Author

@kevinkhill you might want to check out #322

@kevinkhill
Copy link
Owner

Could you try the latest tag? I have other users reporting no more issues.

@kevinkhill
Copy link
Owner

@jackwh
Copy link

jackwh commented Nov 25, 2020

@kevinkhill 3.1.14 seems to have fixed this. Thanks for putting together this package, it's very much appreciated!

@kevinkhill kevinkhill unpinned this issue Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants