Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTree issues #58

Open
heniotierra opened this issue Aug 29, 2018 · 0 comments
Open

BTree issues #58

heniotierra opened this issue Aug 29, 2018 · 0 comments

Comments

@heniotierra
Copy link

Hi,

I think I have found a few problems with the BTree implementation.

  1. Not sure if this is really a problem, but the same key can be inserted multiple times;

  2. If the same key is inserted more than M-1 times, there will be a split, and only the M/2 keys of the new node will be accessible, while the other ones will be forever inaccessible;

  3. When a slipt occurs, the old node keeps the keys that were sent to the new node, even though they now inaccessible in that node; again, this may not be a problem;

  4. When a key is removed, the method still increments the size counter, instead of decreasing it;

Since I am using the this BTree implementation, I have fixed these problems on my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant