Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opening external links does not open url in contained tab anymore #68

Closed
kesselborn opened this issue Oct 19, 2017 · 5 comments
Closed

Comments

@kesselborn
Copy link
Owner

should be connected to the changes yesterday :/

@grahamperrin
Copy link
Contributor

If it helps: not reproducible here with 0.0.65 on Firefox 56.0.1 on FreeBSD-CURRENT.

(Do we have a shared understanding of 'external link'?)

As a test:

  1. allow movement
  2. “Always Open in This Container” for entire domains/to include subdomains? mozilla/multi-account-containers#473 (comment) non-contained
  3. contain it
  4. Control-Click the one link within that comment
  5. observe https://developer.mozilla.org/en-US/docs/Web/Security/Same-origin_policy (external to GitHub) in the same container.

Tentatively reading this alongside https://github.com/kesselborn/conex/issues/66#issuecomment-337915827, @kesselborn have you encountered transient failures and if so: can you recall, with certainty, whether the Conex icon was visible in e.g. the toolbar at those moments?

@kesselborn
Copy link
Owner Author

no, with external link I mean: having a contained tab open and then clicking a link in an external program (e.g. email client) -- this link used to be opened in the same container as the last active tab.
Thinking about it: I am not even sure if this is a good idea of if links from external programs should just be opened non-contained.

@grahamperrin
Copy link
Contributor

grahamperrin commented Oct 25, 2017

Weird, I thought that I had posted more here. Probably drafted and (session storage) saved but lost through a crash that spoiled the store :-(

Note to self, before I forget … oh :-( the thoughts all gone … something with reference to Bugzilla@Mozilla, maybe … hoping it'll come back … postscript: not Bugzilla, it was with reference to Mozilla Discourse …

Whilst I can't recall exactly what was lost here, part of it involved post 10 (2017-05-21) under Move tab from container or to container - Test Pilot / Containers - Mozilla Discourse

@grahamperrin
Copy link
Contributor

Oh hurrah, I found the earlier draft, in a distant tab. Below, and I'm gonna click 'Comment' without checking for completeness … want to not lose track of this again …


… clicking a link in an external program (e.g. email client) …

OK, that's reproducible. I had no experience of prior behaviour.

For what it's worth, the e-mail client use case is within https://discourse.mozilla.org/t/-/14134/10?u=grahamperrin with (I reckon) this keyword, quoted:

  • cumbersome

– then I rambled about potential for cumbersomeness. Is non-contained by default good, or bad? Right now, I can't say …


Hey, today with this issue 68, by coincidence, clicks on a seemingly harmless http:// link in Thunderbird led, at least twice, to some extremely weird behaviours in Firefox 56.0.1, most of which I'll treat as off-topic (because of my exotic mix of extensions). However I whittled down all of that weirdness, to this – in safe mode:

– given the single click in Thunderbird that sort of led me to the clear drag-and-drop case, I'm toying with the possibility of edge case pollution of results, from other testers, where tabs in Firefox are added as a result of other external methods (e.g. not limited to drag-and-drop).

@kesselborn
Copy link
Owner Author

17ecccb is trying to fix the bug ... I will run it for a few days and check how it feels. Will release 0.5.0 to github only as I have to play around with it for a few days -- feel free to install 0.5.0 from github and report back how it feels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants