Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On enter, automatically open top most hit #195

Closed
psamim opened this issue Mar 16, 2018 · 3 comments
Closed

On enter, automatically open top most hit #195

psamim opened this issue Mar 16, 2018 · 3 comments

Comments

@psamim
Copy link

psamim commented Mar 16, 2018

Hi,

When I want to go to a container, I hit ctrl-space, start typing "Wo", "Work" appears at the top of list as the first match. I expect by hitting enter I can go to the first result, which is "Work". But actually I have to hit one extra tab key to select (activate) the first result and then hit enter.

Can we remove the need for that one extra tab key?

Thanks

@kesselborn
Copy link
Owner

kesselborn commented Mar 16, 2018 via email

@grahamperrin
Copy link
Contributor

grahamperrin commented Mar 17, 2018

I expect the initial Tab to focus on the disclosed container – as it already does … sometimes.

Expected, when focus (after one Tab) is on the container

  • (left) should close the container, should rotate the disclosure triangle 90° counterclockwise

Actual result, when focus is on the container

  • behaves as if focus is still on the search field (not the container), and clears the entire entry.

Other times

The initial Tab unexpectedly skips the disclosed container, focuses on what's below.

@kesselborn kesselborn changed the title UX suggestion On enter, automatically open top most hit Mar 31, 2018
@ghost ghost removed the work in progress label Apr 1, 2018
@kesselborn
Copy link
Owner

mmm ... I think I understand what you mean. The behavior at the moment is as follows:

When a search was started, containers can only be focused if the search matches their title, otherwise you focus the first tab within the container that matches the search.

I.e.: if you have a container called "news" with a tab that has "news.cnn.com" open and you search for "cnn", the container will not get the focus as the search does not match. If you searched for "news", both elements, container and the tab, would be focusable, as "news" matches both items.

I created a followup issue for this: #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants