DSA Conduit Interface is not Always Detected

[wkz]

Current Behavior

In this regression test suite run, all tests failed: https://gist.github.com/ael-bot/5fd102d6b9c777810fa8fa1c120fe553

This stemmed from the fact that no port interfaces were brought up:

admin@test-05-24-67:~$ ipb l
lo               UP             00:00:00:00:00:00 <LOOPBACK,UP,LOWER_UP>
eth0             UP             94:de:0e:05:24:67 <BROADCAST,MULTICAST,UP,LOWER_UP>
eth1             UP             94:de:0e:05:24:67 <BROADCAST,MULTICAST,UP,LOWER_UP>
e10@eth0         DOWN           94:de:0e:05:24:71 <BROADCAST,MULTICAST>
e9@eth0          DOWN           94:de:0e:05:24:70 <BROADCAST,MULTICAST>
e12@eth0         DOWN           94:de:0e:05:24:73 <BROADCAST,MULTICAST>
e11@eth0         DOWN           94:de:0e:05:24:72 <BROADCAST,MULTICAST>
e18@eth0         DOWN           94:de:0e:05:24:79 <BROADCAST,MULTICAST>
e17@eth0         DOWN           94:de:0e:05:24:78 <BROADCAST,MULTICAST>
e20@eth0         DOWN           94:de:0e:05:24:7b <BROADCAST,MULTICAST>
e19@eth0         DOWN           94:de:0e:05:24:7a <BROADCAST,MULTICAST>
e15@eth0         DOWN           94:de:0e:05:24:76 <BROADCAST,MULTICAST>
e2@eth0          DOWN           94:de:0e:05:24:69 <BROADCAST,MULTICAST>
e1@eth0          DOWN           94:de:0e:05:24:68 <BROADCAST,MULTICAST>
e4@eth0          DOWN           94:de:0e:05:24:6b <BROADCAST,MULTICAST>
e3@eth0          DOWN           94:de:0e:05:24:6a <BROADCAST,MULTICAST>
e6@eth0          DOWN           94:de:0e:05:24:6d <BROADCAST,MULTICAST>
e5@eth0          DOWN           94:de:0e:05:24:6c <BROADCAST,MULTICAST>
e8@eth0          DOWN           94:de:0e:05:24:6f <BROADCAST,MULTICAST>
e7@eth0          DOWN           94:de:0e:05:24:6e <BROADCAST,MULTICAST>
e14@eth0         DOWN           94:de:0e:05:24:75 <BROADCAST,MULTICAST>
e13@eth0         DOWN           94:de:0e:05:24:74 <BROADCAST,MULTICAST>
e16@eth0         DOWN           94:de:0e:05:24:77 <BROADCAST,MULTICAST>
e22@eth0         DOWN           94:de:0e:05:24:7d <BROADCAST,MULTICAST>
e21@eth0         DOWN           94:de:0e:05:24:7c <BROADCAST,MULTICAST>
e24@eth0         DOWN           94:de:0e:05:24:7f <BROADCAST,MULTICAST>
e23@eth0         DOWN           94:de:0e:05:24:7e <BROADCAST,MULTICAST>
e26@eth0         DOWN           94:de:0e:05:24:81 <BROADCAST,MULTICAST>
e25@eth0         DOWN           94:de:0e:05:24:80 <BROADCAST,MULTICAST>
e28@eth0         DOWN           94:de:0e:05:24:83 <BROADCAST,MULTICAST>
e27@eth0         DOWN           94:de:0e:05:24:82 <BROADCAST,MULTICAST>

A trained eye might also notice that eth0 has not been renamed to dsa0, which means it was not properly detected as a DSA conduit by /usr/libexec/infix/init.d/20-nameif.

A look through the log confims this:

admin@test-05-24-67:~$ log | tail -n 1000 | grep nameif
Jul  2 13:00:21 infix ixinit[1941]: Calling /usr/libexec/infix/init.d/20-nameif ...
Jul  2 13:00:21 infix 20-nameif: calling nameif -c /etc/mactab
Jul  2 13:00:21 infix ixinit[1941]: [ OK ]  /usr/libexec/infix/init.d/20-nameif

Compared to another system where the port was renamed:

admin@test-ad-00-00:~$ log | tail -n 1000 | grep nameif
Nov 15 18:35:09 infix ixinit[2256]: Calling /usr/libexec/infix/init.d/20-nameif ...
Nov 15 18:35:09 infix 20-nameif: calling nameif -c /etc/mactab
Nov 15 18:35:09 infix 20-nameif: Found DSA interface, renaming eth0 -> dsa0
Nov 15 18:35:09 infix ixinit[2256]: [ OK ]  /usr/libexec/infix/init.d/20-nameif

Hypothesis

nameif races against the insertion of the tag_dsa module.

Expected Behavior

DSA conduit detection works every time

Steps To Reproduce

No response

Additional information

No response